Add flags for delete behaviour of authz scopes and policies #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #905 +/- ##
=========================================
Coverage 95.53% 95.53%
- Complexity 1322 1324 +2
=========================================
Files 78 78
Lines 4273 4279 +6
Branches 475 477 +2
=========================================
+ Hits 4082 4088 +6
Misses 91 91
Partials 100 100
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Thanks @f11h for your contribution! Would you mind squashing your commits into one for this PR? |
f11h
force-pushed
the
feat/add-flags-for-authz-scopes-and-policies
branch
from
1b3b63e to
8c8b720
Compare
|
Hi @thomasdarimont - Done! |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Remotly managed authz scopes and policies will be deleted if they are not defined in the realm-config.
Especially (user related) policies need to be set up based on the existing users and their rights. The user policies will grow with growing user base. Users and their specific permissions should not be configured through the realm-config.
To prevent the tool to delete the existing policies and scopes I introduced 2 new config flags to select a no-delete mode (like it already exists for authz resources)
Which issue this PR fixes:
fixes #783
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR